Preserve executable permissions when installing scripts #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scripts use a "shebang" to indicate what interpreter to use when directly invoking them from a shell, however when they are installed, the executable permissions are dropped meaning that they actually can't be invoked directly from a shell. An alternative to this change might be to drop the "shebang" from the scripts if they are intended to be invoked explicitly using the desired interpreter, i.e. `sh tools/doc_check.sh`. Signed-off-by: Scott K Logan <[email protected]>
mjcarroll
approved these changes
Jan 24, 2024
scpeters
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
These scripts use a "shebang" to indicate what interpreter to use when directly invoking them from a shell, however when they are installed, the executable permissions are dropped meaning that they actually can't be invoked directly from a shell.
An alternative to this change might be to drop the "shebang" from the scripts if they are intended to be invoked explicitly using the desired interpreter, i.e.
sh tools/doc_check.sh.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.